Conversation
0f611dc to
7c29a87
Compare
mnmaita
left a comment
There was a problem hiding this comment.
Awesome work here, looking forward to see this merged and released! I guess there's just a dependency bump blocker so I'm leaving an approval (with some minor nits).
On a different note, it would be great to see Required Components implemented in this library in future iterations.
|
Sorry but I did not check the CI failures but they seem pretty straightforward: That's probably because And then there's a ton of lifetime elision lints ( |
|
Thanks for your reviews!
|
064be4c to
9e59c79
Compare
65edd44 to
fd85257
Compare
…mbiguous conflicting system ordering
fd85257 to
ab4fc3c
Compare
Co-authored-by: Sébastien Crozet <sebastien@crozet.re>
|
when will this be merged? anything remaining? because almost all things are done except followups |
@Abhinavpatel00 This PR has been merged and the crates have been released now 👌 |
thank you for your great work :) |
Follow ups
Those are outside of scope for this PR:
background